From 861d18484f0567c7024fe3fe37a7daa4610f6d77 Mon Sep 17 00:00:00 2001 From: rmanach Date: Sun, 24 Sep 2023 15:44:30 +0200 Subject: [PATCH] return bad request on creation bad inputs --- deployment/views.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/deployment/views.py b/deployment/views.py index 228858e..8ae8be2 100644 --- a/deployment/views.py +++ b/deployment/views.py @@ -134,12 +134,14 @@ def create(request): ) form = DeploymentForm(request.POST) - if form.is_valid(): - try: - Deployment.objects.create( - user=request.user, id=uuid4(), **form.cleaned_data - ) - except Exception as e: - return HttpResponseServerError(e) + if not form.is_valid(): + return HttpResponseBadRequest(f"deployment creation inputs are invalid: {form.errors}") + + try: + Deployment.objects.create( + user=request.user, id=uuid4(), **form.cleaned_data + ) + except Exception as e: + return HttpResponseServerError(e) return HttpResponseRedirect("/deployment")